Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix: Space scope header overflow #11933

Merged
merged 15 commits into from
Nov 29, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Nov 27, 2023

Fixes element-hq/element-web#26645

  • clamps space scope header to one line, adds title attribute to show full title
  • extracts scope header into component
  • updates ThirdPartyRoomMemberInfo to use BaseCard and compound components
  • puts scope header into BaseCard header in all screens

Before:
Screenshot 2023-11-27 at 14 02 23
Screenshot 2023-11-27 at 14 02 37
Screenshot 2023-11-27 at 16 15 37

Screenshot 2023-11-27 at 16 16 02

After:
Screenshot 2023-11-27 at 14 28 26
Screenshot 2023-11-27 at 14 28 34
Screenshot 2023-11-27 at 14 46 34
Screenshot 2023-11-27 at 14 46 41

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

@kerryarchibald kerryarchibald added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Nov 27, 2023
Merged via the queue into develop with commit 1ffa1c9 Nov 29, 2023
24 checks passed
@kerryarchibald kerryarchibald deleted the kerry/26645/room-details-overflow branch November 29, 2023 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space member list title partially outside of browser viewport
2 participants