From e14f5efee762878cec79f0c8648e9f5e84f03de3 Mon Sep 17 00:00:00 2001 From: Brad Murray Date: Thu, 28 Oct 2021 22:59:14 -0400 Subject: [PATCH 1/2] Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange --- src/stores/room-list/algorithms/Algorithm.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/stores/room-list/algorithms/Algorithm.ts b/src/stores/room-list/algorithms/Algorithm.ts index 5e98ef37ffb..a139130df46 100644 --- a/src/stores/room-list/algorithms/Algorithm.ts +++ b/src/stores/room-list/algorithms/Algorithm.ts @@ -722,7 +722,8 @@ export class Algorithm extends EventEmitter { cause = RoomUpdateCause.Timeline; didTagChange = true; } else { - cause = RoomUpdateCause.Timeline; + // This is a tag change update and no tags were changed, nothing to do! + return; } if (didTagChange && isSticky) { From 455bb6d22bbcb02340400072f9f8ce1dd385114c Mon Sep 17 00:00:00 2001 From: Brad Murray Date: Fri, 29 Oct 2021 07:08:28 -0400 Subject: [PATCH 2/2] Update src/stores/room-list/algorithms/Algorithm.ts Co-authored-by: Travis Ralston --- src/stores/room-list/algorithms/Algorithm.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stores/room-list/algorithms/Algorithm.ts b/src/stores/room-list/algorithms/Algorithm.ts index a139130df46..754e1c1d946 100644 --- a/src/stores/room-list/algorithms/Algorithm.ts +++ b/src/stores/room-list/algorithms/Algorithm.ts @@ -723,7 +723,7 @@ export class Algorithm extends EventEmitter { didTagChange = true; } else { // This is a tag change update and no tags were changed, nothing to do! - return; + return false; } if (didTagChange && isSticky) {