Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Move from browser-request to fetch #9345

Merged
merged 44 commits into from
Oct 12, 2022
Merged

Move from browser-request to fetch #9345

merged 44 commits into from
Oct 12, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 4, 2022 •
edited by github-actions bot
Loading

Requires matrix-org/matrix-js-sdk#2719

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 4, 2022
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
dbedcfb 
… t3chguy/fetch

� Conflicts:
�	src/components/structures/UploadBar.tsx
@t3chguy t3chguy changed the title Update to new js-sdk upload signatures Move from browser-request to fetch Oct 5, 2022
@t3chguy t3chguy mentioned this pull request Oct 5, 2022
Merged
@t3chguy t3chguy marked this pull request as ready for review October 12, 2022 09:55
@t3chguy t3chguy requested a review from a team as a code owner October 12, 2022 09:55
turt2live
turt2live approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm - seems like this has a couple other fixes in it too, so would be good to get this merged asap.

src/models/RoomUpload.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy merged commit 8b54be6 into develop Oct 12, 2022
@t3chguy t3chguy deleted the t3chguy/fetch branch October 12, 2022 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @turt2live