Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Persistent Data Unit schema in SS API broken #3257

Closed
aaronraimist opened this issue Jun 24, 2021 · 3 comments
Closed

Link to Persistent Data Unit schema in SS API broken #3257

aaronraimist opened this issue Jun 24, 2021 · 3 comments
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@aaronraimist
Copy link
Contributor

Link to problem area: https://spec.matrix.org/unstable/server-server-api/#adding-hashes-and-signatures-to-outgoing-events

Issue:

@aaronraimist aaronraimist added the spec-bug Something which is in the spec, but is wrong label Jun 24, 2021
@aaronraimist
Copy link
Contributor Author

It looks like in previous versions of the spec such as https://matrix.org/docs/spec/server_server/r0.1.4#id98 this just linked to https://matrix.org/docs/spec/server_server/r0.1.4#persistent-data-unit-schema which doesn't actually contain an example of a signed event. It just links you to the room versions spec to find an example.

@turt2live
Copy link
Member

It just links you to the room versions spec to find an example.

It used to contain the schema, but that was moved out with the format changes. Theory at the time was that we could just keep the PDU schema links around until someone refactored each section to optimize the link, but that hasn't exactly happened at a reliable speed :p

@aaronraimist
Copy link
Contributor Author

Fixed by #3528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

No branches or pull requests

2 participants