Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "is a valid event" requirement in PDU checks #3357

Closed
tulir opened this issue Aug 24, 2021 · 2 comments
Closed

Clarify "is a valid event" requirement in PDU checks #3357

tulir opened this issue Aug 24, 2021 · 2 comments
Labels
clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation)

Comments

@tulir
Copy link
Member

tulir commented Aug 24, 2021

Link to problem area: https://spec.matrix.org/unstable/server-server-api/#checks-performed-on-receipt-of-a-pdu

Issue: The first check, "Is a valid event, otherwise it is dropped.", could be interpreted as validating the entire event, including the content. Only validating the top-level keys seems more reasonable (related: #2801), but either way it should be specified explicitly.

Context: Conduit interpreted the requirement as validating the content, and is validating the content of m.room.create events, which leads to being unable to join rooms where the predecessor doesn't contain a valid event ID (there's no explicitly defined validation of predecessor in auth rules or other such places)

@tulir tulir added the clarification An area where the spec could do with being more explicit label Aug 24, 2021
@uhoreg uhoreg added the s2s Server-to-Server API (federation) label Aug 24, 2021
@richvdh
Copy link
Member

richvdh commented Aug 25, 2021

I think this is a dup of matrix-org/matrix-spec#365?

@tulir
Copy link
Member Author

tulir commented Aug 25, 2021

I guess yeah, but there has been no progress on that issue 😿

@tulir tulir closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation)
Projects
None yet
Development

No branches or pull requests

3 participants