Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec asks homeservers to error on /account/3pid/add and in certain cases but does not specify an appropriate status code/errcode for the response #1426

Open
anoadragon453 opened this issue Feb 1, 2023 · 0 comments
Open

Spec asks homeservers to error on /account/3pid/add and in certain cases but does not specify an appropriate status code/errcode for the response #1426

anoadragon453 opened this issue Feb 1, 2023 · 0 comments
Labels
A-Client-Server Issues affecting the CS API

Comments

@anoadragon453
Copy link
Member

In the description of POST /_matrix/client/v3/account/3pid/add there is a line that states:

Homeservers should prevent the caller from adding a 3PID to their account if it has already been added to another user’s account on the homeserver.

However, only 200, 401 and 429 error codes are specified - none of which are appropriate for informing the client that the association has been rejected.

I propose we follow the example of POST /_matrix/client/v3/register/email/requestToken and specify that 400 / M_THREEPID_IN_USE be used in this case.

I believe that this is a good rule to have in the spec. Note that this would require an MSC, as I'm not aware of any homeserver implementations that even enforce this currently.

Related: #520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Client-Server Issues affecting the CS API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anoadragon453 @richvdh