Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document why /state_ids can respond with a 404 #1521

Merged
merged 5 commits into from
May 31, 2023

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented May 12, 2023

Document why /state_ids can respond with a 404

As discussed in an internal room

Preview: https://pr1521--matrix-spec-previews.netlify.app

@MadLittleMods MadLittleMods requested a review from a team as a code owner May 12, 2023 22:26
Comment on lines +145 to +148
application/json: {
"errcode": "M_NOT_FOUND",
"error": "Could not find event $Rqnc-F-dvnEYJTyHq_iKxU2bZ1CI92-kuZq3a5lr5Zg"
}
Copy link
Contributor Author

@MadLittleMods MadLittleMods May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually experienced this response personally (because I'm not a server to observe) but Synapse does error with these in the logs:

SynapseError: 404 - State not known at event $-04o8ieIyqp4uhGC1u3RbrW_991wYR3Tp3jqeVLUAAM
SynapseError: 404 - Could not find event $2k0rFR9Msehfk9bNCWo3eTvT1QQUwEgOXlVsQ_FNEhM

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, but please could you add a newsfragment?

@MadLittleMods MadLittleMods requested a review from richvdh May 30, 2023 16:20
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanking you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants