Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that room avatars cannot be encrypted #1871

Merged

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 14, 2024

Duplicating the info yaml isn't great but I think it'll be easier to wrangle than making the individual parameters reusable.

$ diff data/event-schemas/schema/core-event-schema/msgtype_infos/image_info.yaml data/event-schemas/schema/core-event-schema/msgtype_infos/avatar_info.yaml
1c1
< description: Metadata about an image.
---
> description: Metadata about an avatar image.
22d21
<       Only present if the thumbnail is unencrypted.
24,30d22
<   thumbnail_file:
<     description: |-
<       Information on the encrypted thumbnail file, as specified in
<       [End-to-end encryption](/client-server-api/#sending-encrypted-attachments).
<       Only present if the thumbnail is encrypted.
<     title: EncryptedFile
<     type: object
35c27
< title: ImageInfo
---
> title: AvatarInfo

Fixes: #562

Pull Request Checklist

Preview: https://pr1871--matrix-spec-previews.netlify.app

Fixes: matrix-org#562
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes marked this pull request as ready for review June 14, 2024 13:35
@Johennes Johennes requested a review from a team as a code owner June 14, 2024 13:35
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richvdh richvdh merged commit 7820771 into matrix-org:main Jun 25, 2024
12 checks passed
@zecakeh zecakeh mentioned this pull request Sep 5, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec claims that the room avatar can be encrypted
2 participants