Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove confusing description of restricted rooms with no valid conditions #1903

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

Kladki
Copy link
Contributor

@Kladki Kladki commented Jul 6, 2024

Fixes #1891

I tried changing the wording, but I couldn't think of something that isn't either verbose or confusing. The auth rules already cover the proper behavior anyways

Pull Request Checklist

Preview: https://pr1903--matrix-spec-previews.netlify.app

…ions

Signed-off-by: Matthias Ahouansou <matthias@ahouansou.cz>
@Kladki Kladki requested a review from a team as a code owner July 6, 2024 08:24
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, these changes really help developers down the line 🙂

changelogs/client_server/newsfragments/1903.clarification Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 enabled auto-merge (squash) July 17, 2024 14:25
@anoadragon453 anoadragon453 merged commit 149d5d2 into matrix-org:main Jul 17, 2024
12 checks passed
@zecakeh zecakeh mentioned this pull request Sep 5, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour of restricted rooms with no valid conditions is not clear
3 participants