Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for MSC4163: Make ACLs apply to EDUs #2004

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Nov 19, 2024

Spec for MSC4163.

Fixes: #1784

Pull Request Checklist

Preview: https://pr2004--matrix-spec-previews.netlify.app

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@@ -1228,7 +1228,6 @@ of `M_FORBIDDEN`.

The following endpoint prefixes MUST be protected:

- `/_matrix/federation/v1/send` (on a per-PDU basis)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this down in order to detail the behaviour of the endpoint and because the description above with HTTP 403 and errcode cannot actually be applied to it.

@Johennes Johennes marked this pull request as ready for review November 19, 2024 09:52
@Johennes Johennes requested a review from a team as a code owner November 19, 2024 09:52
@clokep clokep requested a review from a team November 19, 2024 15:26
@turt2live turt2live changed the title MSC4163: Make ACLs apply to EDUs Add spec for MSC4163: Make ACLs apply to EDUs Nov 19, 2024
@zecakeh
Copy link
Contributor

zecakeh commented Nov 28, 2024

Should we consider that this fixes #1784?

content/server-server-api.md Outdated Show resolved Hide resolved
content/server-server-api.md Outdated Show resolved Hide resolved
content/server-server-api.md Outdated Show resolved Hide resolved
Johennes and others added 2 commits December 11, 2024 08:33
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@Johennes Johennes requested a review from richvdh December 11, 2024 12:36
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@richvdh richvdh merged commit 355f92f into matrix-org:main Dec 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how implementations of federation /send are to apply Server Access Control Lists on a "per PDU basis"
4 participants