Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression introduced when inlining "Required" #2005

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Nov 19, 2024

This was a regression in the rendered spec introduced in #1969.

If the description is not set in the object definition, Hugo generates a weird string after "Required": %!s(<nil>).

To avoid that, we default the description to an empty string when it is not set.

Example, in the m.text definition:

Before:

image

After:

image

Pull Request Checklist

Preview: https://pr2005--matrix-spec-previews.netlify.app

If the description is not set in the object definition, Hugo generates a weird string after "Required": `%!s(<nil>)`.

To avoid that, we default the description to an empty string when it is not set.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner November 19, 2024 10:23
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@richvdh richvdh changed the title Fix regression introduced when inlining "Required" with description Fix regression introduced when inlining "Required" Nov 26, 2024
@richvdh richvdh merged commit f3130f7 into matrix-org:main Nov 26, 2024
12 checks passed
@zecakeh zecakeh deleted the fix-required-nil branch November 26, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants