Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit error:preparing if we fire preparing but never make it to ready #87

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Emit error:preparing if we fire preparing but never make it to ready #87

merged 1 commit into from
Jul 26, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 26, 2023 •
edited
Loading

Fixes #88

@t3chguy t3chguy added the enhancement New feature or request label Jul 26, 2023
@t3chguy t3chguy mentioned this pull request Jul 26, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@t3chguy t3chguy marked this pull request as ready for review July 26, 2023 08:19
@t3chguy t3chguy requested a review from a team as a code owner July 26, 2023 08:19
@t3chguy t3chguy requested review from germain-gg and dbkr and removed request for a team July 26, 2023 08:19
germain-gg
germain-gg approved these changes Jul 26, 2023
View reviewed changes
Copy link

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but would it be possible to attach some context?

@t3chguy
Copy link
Member Author

t3chguy commented Jul 26, 2023

@germain-gg sure, attached

@t3chguy t3chguy merged commit ad944d3 into master Jul 26, 2023
@t3chguy t3chguy deleted the t3chguy/cr/73 branch July 26, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr was automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to know that a given widget hasn't and won't reached ready state
2 participants
@t3chguy @germain-gg