Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 13 #94

Closed
ghost opened this issue May 30, 2021 · 3 comments
Closed

Electron 13 #94

ghost opened this issue May 30, 2021 · 3 comments

Comments

@ghost
Copy link

ghost commented May 30, 2021

Is your feature request related to a problem? Please describe.

We have updated Electron to 13.x in nixpkgs, but didn't pin the version used for element-desktop properly. Now we can't add native extensions until they build with Electron 13, since downgrading Electron might break state.

Describe the solution you'd like
Probably update neon to the latest release. Maybe change to N-API?

Describe alternatives you've considered
Patch neon? Probably would need multiple patches though.

Additional context
NixOS/nixpkgs#124907

@poljar
Copy link
Collaborator

poljar commented May 30, 2021

Updating neon is inevitable so that's the way to go, though it's a bit non-trivial since neon-serde seems to be abandoned, so we'll need to get rid of it and neon itself has a new API.

For reference, the migration guide for neon is found here.

@ghost
Copy link
Author

ghost commented May 30, 2021

There is a maintained-ish fork of neon_serde: https://github.com/antonok-edm/neon-serde/tree/refactor/update-neon-0.8

The whole thing is non-trivial, but I think I'm making good progress.

@poljar
Copy link
Collaborator

poljar commented Jul 7, 2021

This has been addressed by #95 and #97.

@poljar poljar closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant