-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron 13 #94
Comments
Updating neon is inevitable so that's the way to go, though it's a bit non-trivial since For reference, the migration guide for |
There is a maintained-ish fork of neon_serde: https://github.com/antonok-edm/neon-serde/tree/refactor/update-neon-0.8 The whole thing is non-trivial, but I think I'm making good progress. |
Is your feature request related to a problem? Please describe.
We have updated Electron to 13.x in nixpkgs, but didn't pin the version used for element-desktop properly. Now we can't add native extensions until they build with Electron 13, since downgrading Electron might break state.
Describe the solution you'd like
Probably update neon to the latest release. Maybe change to N-API?
Describe alternatives you've considered
Patch neon? Probably would need multiple patches though.
Additional context
NixOS/nixpkgs#124907
The text was updated successfully, but these errors were encountered: