Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare the output to the input when testing replication, not the other way around #278

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

babolivier
Copy link
Contributor

Otherwise we don't test if all of the replicated associations have been correctly inserted in the database.

…er way around

Otherwise we don't test if all of the replicated associations have been correctly inserted in the database
@babolivier babolivier requested a review from a team February 24, 2020 17:37
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems plausible

@babolivier babolivier merged commit d4c27a9 into master Feb 26, 2020
@babolivier babolivier deleted the babolivier/test_replication branch September 8, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants