Remove unspecified 'success' parameter from requestToken responses

[babolivier]

It doesn't look like it's ever been a thing in the spec, and we don't seem to be checking this parameter in Synapse.

It can be an issue to have this parameter around for servers that have the setting from matrix-org/synapse#7315 turned on and are delegating emails to an IS, because then you can figure out whether the server is lying to you just by checking on whether there's a success in the response.

[anoadragon453]

My personal theory is that this was just an accidental inclusion due to success being a parameter on the /submitToken endpoint: https://matrix.org/docs/spec/identity_service/latest#post-matrix-identity-v2-validate-email-submittoken

Ideally we would poke a tendril out and ask if any other clients/servers are using this before we remove it.

Edit: I've asked in #matrix-client-developers:matrix.org and #homeservers-dev:matrix.org.

[clokep]

Edit: I've asked in #matrix-client-developers:matrix.org and #homeservers-dev:matrix.org.

Is this waiting for a response or just someone to review the code (or are you already handling that @anoadragon453 ?)

[babolivier]

afaict folks in these rooms have said that they weren't using this parameter so I think this is just waiting for a review.

[anoadragon453]

Community people have already clarified that it's not being used in both clients nor servers, and it's been some time since we've asked now, so I think it's fine from that perspective.

I forget if we asked Riot people though?

[babolivier]

I forget if we asked Riot people though?

I don't think we have, I'm asking internally rn.

[jryans]

It looks fine for Riot Web at least, we don't use this parameter.

[babolivier]

The mobile apps' devs shared that it looks fine from their pov as well.

[anoadragon453]

Seems that this won't break anything, and it is indeed not in the spec.

[anoadragon453]

Oh, actually, last thing. Could you specify when this was introduced in the newsfile? :)

[babolivier]

Oh, actually, last thing. Could you specify when this was introduced in the newsfile? :)

It's always been there apparently, not sure it makes much sense to say so in the changelog.