Support Tox for unit tests and linting #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
clokep
reviewed
Jul 15, 2020
| skip_install = True | ||
| deps = | ||
| # pin deps so we don't start failing when they are updated | ||
| flake8==3.8.3 |
There was a problem hiding this comment.
Not sure if it matters, but we also use flake8-comprehensions on Synapse. Probably should be introduced as a separate PR though.
clokep
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will then use this in CI.
I also updated the CONTRIBUTING documentation to reflect this, and fixed tests so they pass mypy (which is both good for us and makes it easier to use the
lint.shscript).