Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'max_connections' as an understood config field to gcmpushkin #157

Merged
merged 3 commits into from
Dec 11, 2020

Conversation

anoadragon453
Copy link
Member

We were getting the following harmless error in our logs:

[...] sygnal.gcmpushkin 109 - WARNING - The following configuration fields are not understood: {'max_connections'}

However this option is documented in the sample config:

sygnal/sygnal.yaml.sample

Lines 245 to 247 in 08318c8

# # This is the maximum number of connections to GCM servers at any one time
# # the default is 20.
# #max_connections: 20

and used in the codebase:

sygnal/sygnal/gcmpushkin.py

Lines 114 to 116 in 0672a84

self.max_connections = self.get_config(
"max_connections", DEFAULT_MAX_CONNECTIONS
)

So it seems like we just forgot to add it to this list while adding the option 🙂

(If you're wondering why inflight_request_limit isn't in this dict either, that's because it's shared across both APNs and GCM pushkin types :)

@anoadragon453 anoadragon453 requested a review from a team December 10, 2020 18:23
changelog.d/157.bugfix Outdated Show resolved Hide resolved
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
@anoadragon453 anoadragon453 merged commit ab87ab8 into master Dec 11, 2020
@anoadragon453 anoadragon453 deleted the anoa/add_max_connections_option branch December 11, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants