Add 'max_connections' as an understood config field to gcmpushkin #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting the following harmless error in our logs:
However this option is documented in the sample config:
sygnal/sygnal.yaml.sample
Lines 245 to 247 in 08318c8
and used in the codebase:
sygnal/sygnal/gcmpushkin.py
Lines 114 to 116 in 0672a84
So it seems like we just forgot to add it to this list while adding the option 🙂
(If you're wondering why
inflight_request_limit
isn't in this dict either, that's because it's shared across both APNs and GCM pushkin types :)