Connection Timeout Error #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade black to the latest version fixes #199 Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
upgrade flake8 to the latest version fixes #199 Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
upgrade mypy to the latest version fixes #199 Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
upgrade mypy-zope to the latest version fixes #199 Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
fixes codestyle by running black on tests/ directory fixes #199 Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
Add connection timeout error code on CONTRIBUTING.mb,the connection timeout error is caused by poor internet connectivity as pip is set to default 15 sec. Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
callahad
suggested changes
Apr 12, 2021
Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
callahad
approved these changes
Apr 12, 2021
callahad
suggested changes
Apr 12, 2021
| @@ -1 +1 @@ | |||
| Upgrade development dependencies fixes #199. Contributed by Omar Mohamed | |||
| Upgrade development dependencies fixes #199. Contributed by Omar Mohamed. | |||
There was a problem hiding this comment.
Oops! I noticed one final thing right before I hit merge 😆
Could you please rename this file to 215.misc instead of 214.misc, and maybe change the description to more closely match (e.g., "Add note about pip timeouts. Contributed by Omar Mohamed.")
There was a problem hiding this comment.
On it 😃
I just realized 214.misc was a PR on #199 issue and 215.doc is for this pip timeout error. Do you want it changed to be one changelog, or I change 215.doc to 215.misc
There was a problem hiding this comment.
215.doc here would be fine :)
There was a problem hiding this comment.
I have made changes on the 215.doc changelog file with a more descriptive message on pip timeout, Thank you 😃
Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
callahad
approved these changes
Apr 13, 2021
callahad
pushed a commit
that referenced
this pull request
Apr 13, 2021
Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
|
I manually merged this in 7a3d6f8 with a few small tweaks -- thank you again 😄 |
Thank you so much 😃 |
awesome-michael
added a commit
to Awesome-Technologies/sygnal
that referenced
this pull request
May 6, 2021
Sygnal 0.9.3 (2021-04-22) ========================= Features -------- - Prevent the push key from being rejected for temporary errors and oversized payloads, add TTL logging, and support `events_only` push data flag. ([\matrix-org#212](matrix-org#212)) - WebPush: add support for Urgency and Topic header ([\matrix-org#213](matrix-org#213)) Bugfixes -------- - Fix a long-standing bug where invalid JSON would be accepted over the HTTP interfaces. ([\matrix-org#216](matrix-org#216)) - Limit the size of requests received from HTTP clients. ([\matrix-org#220](matrix-org#220)) Updates to the Docker image --------------------------- - Remove manually added GeoTrust Root CA certificate from docker image as Apple is no longer using it. ([\matrix-org#208](matrix-org#208)) Improved Documentation ---------------------- - Make `CONTIBUTING.md` more explicit about how to get tests passing. ([\matrix-org#188](matrix-org#188)) - Update `CONTRIBUTING.md` to specify how to run code style and type checks with Tox, and add formatting to code block samples. ([\matrix-org#193](matrix-org#193)) - Document how to work around pip installation timeout errors. Contributed by Omar Mohamed. ([\matrix-org#215](matrix-org#215)) Internal Changes ---------------- - Update Tox to run in the installed version of Python (instead of specifying Python 3.7) and to consider specific paths and folders while running checks, instead of the whole repository (potentially including unwanted files and folders, e.g. the virtual environment). ([\matrix-org#193](matrix-org#193)) - Make development dependencies available as extras. Contributed by Hillery Shay. ([\matrix-org#194](matrix-org#194)) - Update `setup.py` to specify that a minimum version of Python greater or equal to 3.7 is required. Contributed by Tawanda Moyo. ([\matrix-org#207](matrix-org#207)) - Port CI checks to Github Actions. ([\matrix-org#210](matrix-org#210), [\matrix-org#219](matrix-org#219)) - Upgrade development dependencies. Contributed by Omar Mohamed ([\matrix-org#214](matrix-org#214)) - Set up `coverage.py` to run in tox environment, and add html reports ([\matrix-org#217](matrix-org#217)) Change-Id: I14ae821ff2a1562e91fd87ce25f73baaa0b9430b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add connection timeout error code on
CONTRIBUTING.mb, the connection timeouterror is caused by poor internet connectivity as
pipis set to default 15 sec.When running this command with slow internet then
pipthrows a connection time error aspipis set to the default of 15 sec to download any dependencypython3 -m venv venv ./venv/bin/pip install -e '.[dev]'