Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the docker build: Install git in the docker image builder #246

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

reivilibre
Copy link
Contributor

Fixes #244 .

@reivilibre reivilibre requested a review from a team August 9, 2021 17:42
@clokep
Copy link
Member

clokep commented Aug 9, 2021

@reivilibre Needs a newsfile, but seems OK.

Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
docker/Dockerfile Outdated Show resolved Hide resolved
changelog.d/246.bugfix Outdated Show resolved Hide resolved
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre reivilibre requested a review from clokep August 9, 2021 17:51
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reivilibre reivilibre merged commit 22d452a into main Aug 9, 2021
@reivilibre reivilibre deleted the rei/fix_docker_build branch August 9, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build is broken
2 participants