Build and push docker images using GitHub Actions #249
Conversation
reivilibre
changed the title
.github/workflows/docker_push.yml
Outdated
| # uncomment this to enable all pushes to main | ||
| #branches: [ master, main ] |
There was a problem hiding this comment.
I think latest on our docker images always just points to the latest release. Not sure if we'd ever push on the main branch.
Though you mention re-enabling building docker images on main below - did we used to do that?
There was a problem hiding this comment.
I ripped off https://github.com/matrix-org/synapse/blob/develop/.github/workflows/docker.yml which seems like if you push to master on Synapse, you will get a new build.
I'm not really sure why this is, so I took it out for Sygnal.
There was a problem hiding this comment.
Given we don't have anything other than releases on our dockerhub, I believe that that workflow both tests docker builds as well as publishes them (if the branch has an associated release tag).
This isn't necessary in Sygnal, as we already have a workflow for testing docker builds.
.github/workflows/docker_push.yml
Outdated
|
|
||
| # The following line can be used to tag builds with the SHA hash of the commit. | ||
| # This would be useful if we wanted to re-enable building for all commits on `main`. | ||
| # type=sha,enable=true,priority=100,prefix=,suffix=,format=long |
There was a problem hiding this comment.
This is what would generate the following tag I assume?
There was a problem hiding this comment.
Yeah, that's right. Reckon I should just cut it out entirely?
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
reivilibre
force-pushed
the
rei/docker_build_push
branch
from
5f1c964
to
256cf9a
Compare
|
Now that this is resolved, can we pretty please get a point release tagged and pushed? Looking forward to trying out the db-less sygnal release, but unfortunately the container isn't available on dockerhub. https://hub.docker.com/r/matrixdotorg/sygnal/tags |
That's the plan, yup, sorry for taking my sweet time with it :) |
|
@bradtgmurray 0.10.1 released -- go and have fun! :D |
Closes #245.