Move glob_to_regex to matrix-python-common
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
reviewed
Dec 3, 2021
| @@ -36,6 +36,7 @@ | |||
| "importlib_metadata", | |||
| "pywebpush>=1.13.0", | |||
| "py-vapid>=1.7.0", | |||
| "matrix-common==1.0.0", | |||
There was a problem hiding this comment.
I don't remember if we had a conversation, but 👍 on pinning this. I think we want exact versions here since we're just trying to avoid vendoring this code.
There was a problem hiding this comment.
I seem to remember someone telling me to pin the matrix-common import, but can't remember where that was.
This was referenced Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #268
Part of the work to address #255