Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that the topic is most commonly the Bundle Identifier for the iOS application. #284

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

reivilibre
Copy link
Contributor

It came up in recent troubleshooting for a community member.
It would be useful to spell this out; from screenshots it appeared that the Apple developer site doesn't call it a topic, even though the APNs docs do.

Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
@reivilibre reivilibre requested a review from a team as a code owner December 6, 2021 12:53
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

matrix.org's sygnal instance has a few $bundle_id.voip topics configured. I have no idea when they're used since my phone didn't register a token for one.

@reivilibre
Copy link
Contributor Author

matrix.org's sygnal instance has a few $bundle_id.voip topics configured. I have no idea when they're used since my phone didn't register a token for one.

Yeah I don't really know what that is about. It might have been a historical detail from a previous version of APNs (they were there back when we switched to the new APNs with the Sygnal rewrite 2 years ago!), but I don't know with any certainty. Possibly a question for the iOS devs.

@reivilibre reivilibre merged commit 37038c9 into main Dec 6, 2021
@reivilibre reivilibre deleted the rei/doc/bundle_id branch December 6, 2021 13:25
@DMRobertson
Copy link
Contributor

See https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns

apns-topic
The topic for the notification. In general, the topic is your app’s bundle ID/app ID. It can have a suffix based on the type of push notification. If you’re using a certificate that supports PushKit VoIP or watchOS complication notifications, you must include this header with bundle ID of you app and if applicable, the proper suffix. If you’re using token-based authentication with APNs, you must include this header with the correct bundle ID and suffix combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants