Don't attempt delivery of notification if we have rejected pushkey #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squahtx
reviewed
Jul 29, 2022
squahtx
reviewed
Aug 1, 2022
squahtx
approved these changes
Aug 1, 2022
|
Merged, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we decided to reject pushkeys if
default_payloadwas malformed (i.e. not adict) but went ahead and attempted delivery with the rejected pushkey anyway. This PR fixes that and changes the code so we do not attempt delivery with a pushkey we have rejected.While I was in the area I also downgraded the logging error messages to a warning, to reduce sentry spam. This fixes #314. I also amended the warnings to give a little more information on why the pushkey was being rejected.