Extend logging for outgoing pushes #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
approved these changes
Apr 21, 2023
|
(No idea why flake8 has fallen over. Presumably we don't pin something that we ought to.) |
well, I'm not in a position to investigate myself, and it's blocking the tests. Are you happy for me to mash the merge button without running the tests, or? |
Mash it aggressively; I will to unsadden Sygnal today. |
DMRobertson
pushed a commit
that referenced
this pull request
Apr 21, 2023
DMRobertson
pushed a commit
that referenced
this pull request
Apr 21, 2023
* Move from setup.py to pyproject.toml Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Ensure unit tests run IDK we sometimes have to invoke trial explicitly like this * Use ruff instead of flake8 And remove py2-style type annotations, which ruff doesn't recognise Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Bump GHA actions part of matrix-org/synapse#14203 * Run black Presumably this fixes complaints from #333 and #334 * Move isort config to pyproject * Also lint stubs * Bump GHA actions part of matrix-org/synapse#14203 * Fix an unintended rename in #333 Needed for unit tests to be happy * Changelog --------- Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit more logging is useful for being able to diagnose issues. Log the room id and event id for each push, where we have them.