Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace occurances of 'assertEquals' with 'assertEqual' #93

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Replace occurances of 'assertEquals' with 'assertEqual' #93

merged 2 commits into from
Mar 30, 2020

Conversation

Half-Shot
Copy link
Contributor

The method has been deprecated and was causing a lot of noise in the console.

@richvdh richvdh requested a review from a team March 30, 2020 09:09
clokep
clokep approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty mechanical to me and tests still pass. 🎉

@Half-Shot Half-Shot merged commit 4bb4c17 into master Mar 30, 2020
@Half-Shot Half-Shot deleted the hs/legacy-equals branch March 30, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @clokep