From 60400d053549b26f656daccdd8c2960d5796c63e Mon Sep 17 00:00:00 2001
From: Patrick Cloke <patrickc@matrix.org>
Date: Wed, 13 May 2020 08:11:39 -0400
Subject: [PATCH] Display the actual error when a pushkin cannot be created.

---
 changelog.d/125.misc | 1 +
 sygnal/sygnal.py     | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
 create mode 100644 changelog.d/125.misc

diff --git a/changelog.d/125.misc b/changelog.d/125.misc
new file mode 100644
index 00000000..b053f6a3
--- /dev/null
+++ b/changelog.d/125.misc
@@ -0,0 +1 @@
+Improve logging if a pushkin cannot be created.
diff --git a/sygnal/sygnal.py b/sygnal/sygnal.py
index 969d27dd..963254e7 100644
--- a/sygnal/sygnal.py
+++ b/sygnal/sygnal.py
@@ -190,9 +190,10 @@ async def _make_pushkins_then_start(self, port, bind_addresses, pushgateway_api)
             try:
                 self.pushkins[app_id] = await self._make_pushkin(app_id, app_cfg)
             except Exception:
-                raise RuntimeError(
-                    "Failed to load and create pushkin for kind %s", app_cfg["type"]
+                logger.error(
+                    "Failed to load and create pushkin for kind '%s'" % app_cfg["type"]
                 )
+                raise
 
         if len(self.pushkins) == 0:
             raise RuntimeError(