Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make async/await #41

Open
reivilibre opened this issue Aug 21, 2020 · 1 comment
Open

Make async/await #41

reivilibre opened this issue Aug 21, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@reivilibre
Copy link
Contributor

reivilibre commented Aug 21, 2020 •
edited
Loading

There aren't inlineCallbacks here but it is using callbacks altogether; there may be interest in turning this into readable coroutine code.
@reivilibre reivilibre self-assigned this Aug 21, 2020
@clokep
Copy link
Member

clokep commented Aug 27, 2020

I'm not sure if we mention a minimum Synapse version anywhere, but if we do we'll want to update it to whatever version added support to async/await in the media repo code.

@reivilibre reivilibre removed their assignment Sep 3, 2020
@clokep clokep added the help wanted Extra attention is needed label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clokep @reivilibre