Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make _S3Responder clean up resources on __del__ #76

Open
erikjohnston opened this issue Aug 30, 2022 · 0 comments
Open

Make _S3Responder clean up resources on __del__ #76

erikjohnston opened this issue Aug 30, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@erikjohnston
Copy link
Member

There was a bug in Synapse (matrix-org/synapse#13660) where we didn't correctly call _S3Responder.__exit__, and so the resources were not correctly cleaned up (leading to threadpool exhaustion).

To help mitigate this we should add a __del__ that clears the resources (if not done already) and logs an error.
@squahtx squahtx added the bug Something isn't working label Aug 30, 2022
@erikjohnston erikjohnston added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@squahtx @erikjohnston