From 95a49727a6807e716a2386c6d0b167f29f5f8c9a Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Wed, 20 Oct 2021 18:13:51 +0100 Subject: [PATCH] Note that AS interest via room ID or alias isn't respected Typing and read receipt events (those that are associated with a room) should be sent to an AS that has registered interest in that room, according to MSC2409: https://github.com/Sorunome/matrix-doc/blob/231084da132af6518ecefa2a42c37937dfe373d2/proposals/2409-appservice-edus.md#expectations-of-when-an-edu-should-be-pushed-to-an-appservice --- synapse/handlers/receipts.py | 4 ++++ synapse/handlers/typing.py | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/synapse/handlers/receipts.py b/synapse/handlers/receipts.py index 4911a1153519..9fe980e72a94 100644 --- a/synapse/handlers/receipts.py +++ b/synapse/handlers/receipts.py @@ -267,6 +267,10 @@ async def get_new_events_as( ) # Then filter down to rooms that the AS can read + # TODO: This doesn't seem to honour an appservice's registration of room or + # namespace aliases. For instance, if an appservice registered a room namespace + # that matched this room, but it didn't have any members in the room, then that + # appservice wouldn't receive the read receipt. events = [] for room_id, event in rooms_to_events.items(): if not await service.matches_user_in_member_list(room_id, self.store): diff --git a/synapse/handlers/typing.py b/synapse/handlers/typing.py index 662ea59d420c..7290eecfa1e2 100644 --- a/synapse/handlers/typing.py +++ b/synapse/handlers/typing.py @@ -481,6 +481,11 @@ async def get_new_events_as( for room_id in handler._room_serials.keys(): if handler._room_serials[room_id] <= from_key: continue + + # TODO: This doesn't seem to honour an appservice's registration of room or + # namespace aliases. For instance, if an appservice registered a room namespace + # that matched this room, but it didn't have any members in the room, then that + # appservice wouldn't receive the typing event. if not await service.matches_user_in_member_list( room_id, handler.store ):