Docs mistakenly refer to nonexistant custom_template_directory config option?

[callahad]

From a cursory glance, it appears that:

1. Centralise the custom template directory #10596 added the custom_template_directory config option + docs
2. Allow using several custom template directories #10587 renamed it to custom_template_directories but did not update the docs.

Thus, https://matrix-org.github.io/synapse/v1.41/templates.html still refers to setting it as:

templates:
  custom_templates_directory: /path/to/custom/templates/

instead of what I would expect:

templates:
  custom_templates_directories:
    - /path/to/custom/templates/

The sample_config.yaml does the same thing, and grepping turns up a few other reference to custom_template_directory which I've not investigated.

Assigning to @babolivier to tell me if I'm a crank or not.

If I'm not a crank, I'd like this to be fixed in the 1.41 release branch then merged down to develop since we're planning on a point release anyways...

[callahad]

I'm very likely a crank; it's late.

[callahad]

Pretty sure I'm a crank. See lines 717-719 from /synapse/config/server.py in 1.41.0:

synapse/synapse/config/server.py

Lines 713 to 723 in f03cafb

	templates_config = config.get("templates") or {}
	if not isinstance(templates_config, dict):
	raise ConfigError("The 'templates' section must be a dictionary")
	self.custom_template_directory = templates_config.get(
	"custom_template_directory"
	)
	if self.custom_template_directory is not None and not isinstance(
	self.custom_template_directory, str
	):
	raise ConfigError("'custom_template_directory' must be a string")