Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

CI run against Twisted trunk is failing #10851

Closed
github-actions bot opened this issue Sep 20, 2021 · 7 comments · Fixed by #10895
Closed

CI run against Twisted trunk is failing #10851

github-actions bot opened this issue Sep 20, 2021 · 7 comments · Fixed by #10895
Assignees
@DMRobertson
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2021 •
edited
Loading

See https://github.com/matrix-org/synapse/actions/runs/1290148067
@DMRobertson DMRobertson added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. X-Needs-Discussion labels Sep 20, 2021
@DMRobertson
Copy link
Contributor

Need to see if this was a one-off or consistent failure.

@clokep
Copy link
Member

clokep commented Sep 20, 2021 

synapse/replication/tcp/redis.py:367: error: Argument 1 to "connectTCP" of "IReactorTCP" has incompatible type "bytes"; expected "str"  [arg-type]

This is due to twisted/twisted#1664

@callahad callahad added the P1 label Sep 23, 2021
@richvdh
Copy link
Member

richvdh commented Sep 23, 2021

(we need to update our call to connectTCP to pass a str where we are currently passing a bytes)

@DMRobertson
Copy link
Contributor

Looks to be just a case of not calling .encode(). But I'm not sure how to make mypy happy with older and newer versions of twisted. I guess we only run mypy in the 3.9 tox environment?

@richvdh
Copy link
Member

richvdh commented Sep 23, 2021

But I'm not sure how to make mypy happy with older and newer versions of twisted

honestly, I suspect you'll need a # type: ignore until the next release of twisted.

@richvdh
Copy link
Member

richvdh commented Sep 23, 2021

(which is what we do elsewhere we call connectTCP - synapse/handlers/send_email.py for example)

@DMRobertson
Copy link
Contributor

Indeed---beat me to it!

@DMRobertson DMRobertson linked a pull request Sep 23, 2021 that will close this issue
Pass str to twisted's IReactorTCP #10895
Merged
@DMRobertson DMRobertson mentioned this issue Sep 23, 2021
Closed
@kittykat kittykat added the z-p1 label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass str to twisted's IReactorTCP matrix-org/synapse
5 participants
@callahad @kittykat @clokep @richvdh @DMRobertson