Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Advertise support for r0.6.1 #11064

Closed
clokep opened this issue Oct 12, 2021 · 3 comments · Fixed by #11097
Closed

Advertise support for r0.6.1 #11064

clokep opened this issue Oct 12, 2021 · 3 comments · Fixed by #11097
Labels
A-Spec-Compliance places where synapse does not conform to the spec T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Oct 12, 2021

Synapse as of #9224 supports r0.6.1 of the Matrix spec, we should advertise support for that.

@clokep clokep added A-Spec-Compliance places where synapse does not conform to the spec T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Oct 12, 2021
@turt2live
Copy link
Member

just ftr: I've done a quick check against the r0.6.1 spec for what other features synapse might be missing, and found none. Looks very safe to advertise the version.

@aaronraimist
Copy link
Contributor

I don't think Element Web handles the version checks correctly. If you go by the spec

Only the latest Z value will be reported for each supported X.Y value. i.e. if the server implements r0.0.0, r0.0.1, and r1.2.0, it will report r0.0.1 and r1.2.0.

Element will think that the server doesn't support r0.6.0 because the version check is very simplistic. https://github.com/matrix-org/matrix-js-sdk/blob/bbc547fd7f8c7a69e5045f50bbc87c22a9c225bf/src/client.ts#L5806-L5814

Filed as matrix-org/matrix-js-sdk#1984

@turt2live
Copy link
Member

The spec is incorrect: the server should be advertising both r0.6.0 and r0.6.1

erikjohnston pushed a commit that referenced this issue Nov 1, 2021
Fixes #11064

Signed-off-by: Aaron Raimist <aaron@raim.ist>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Spec-Compliance places where synapse does not conform to the spec T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants