Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Some device signatures are missing when doing key/query other federation #11159

Closed
BillCarsonFr opened this issue Oct 22, 2021 · 2 comments
Closed

Some device signatures are missing when doing key/query other federation #11159

BillCarsonFr opened this issue Oct 22, 2021 · 2 comments
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-p2 (Deprecated Label)

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Oct 22, 2021 •
edited
Loading

Please refer to this rageshake for full details: https://github.com/matrix-org/element-web-rageshakes/issues/5739

From matrix.org, when doing key/query on a user we can see 2 signatures for the device (device signature and SSK signature)
But when doing from another server the SSK signature is missing

** IMPACT **
=> the user device appears as unverified from federation (red shiel on user and rooms)
@squahtx squahtx added T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Needs-Discussion labels Oct 22, 2021
@erikjohnston
Copy link
Member

This sounds like the problems talked about in #10668 and #10912. We probably want to try and progress the second PR.

@erikjohnston erikjohnston added S-Minor Blocks non-critical functionality, workarounds exist. and removed X-Needs-Discussion labels Oct 29, 2021
@erikjohnston erikjohnston mentioned this issue Nov 2, 2021
Merged
@callahad callahad added the P2 label Nov 4, 2021
erikjohnston added a commit that referenced this issue Nov 9, 2021
@erikjohnston
Include cross-signing signatures when syncing remote devices for the …
af78464 
…first time (#11234)

When fetching remote devices for the first time, we did not correctly include the cross signing keys in the returned results.

c.f. #11159
@erikjohnston erikjohnston removed their assignment Nov 11, 2021
@richvdh
Copy link
Member

richvdh commented Nov 11, 2021

we believe this has likely been fixed by #11234. There may be other causes of the same symptoms, however, so please reopen if this is seen again once Synapse v1.47.0 has rolled out.

@richvdh richvdh closed this as completed Nov 11, 2021
@kittykat kittykat added the z-p2 (Deprecated Label) label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@callahad @kittykat @richvdh @squahtx @erikjohnston @BillCarsonFr