Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Unexpected AuthError from _check_event_auth #11513

Closed
richvdh opened this issue Dec 6, 2021 · 2 comments
Closed

Unexpected AuthError from _check_event_auth #11513

richvdh opened this issue Dec 6, 2021 · 2 comments
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@richvdh
Copy link
Member

richvdh commented Dec 6, 2021

#11011 added a check, boldly asserting that some code was unreachable. The evidence suggests otherwise. We should find out why this is happening.

@richvdh
Copy link
Member Author

richvdh commented Dec 6, 2021

Example stacktrace:

AuthError: 403: Auth events could not be found
  File "synapse/handlers/federation_event.py", line 983, in _process_received_pdu
    context,
  File "synapse/handlers/federation_event.py", line 1371, in _check_event_auth
    origin, event
  File "synapse/handlers/federation_event.py", line 1683, in _load_or_fetch_auth_events_for_event
    raise AuthError(code=HTTPStatus.FORBIDDEN, msg="Auth events could not be found")

https://sentry.matrix.org/sentry/synapse-matrixorg/issues/233645
https://sentry.matrix.org/sentry/synapse-modular/issues/235420

@squahtx squahtx added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Dec 8, 2021
@richvdh
Copy link
Member Author

richvdh commented Jun 30, 2022

#11001 made AuthError a documented exception from _check_event_auth, so the problem is now simply that we log it. Fixed by #13145.

@richvdh richvdh closed this as completed Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

2 participants