Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add direction parameter to /relations api #11926

Closed
ismailgulek opened this issue Feb 7, 2022 · 3 comments · Fixed by #11941
Closed

Add direction parameter to /relations api #11926

ismailgulek opened this issue Feb 7, 2022 · 3 comments · Fixed by #11941
Assignees
Labels
A-Threads Threaded messages T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@ismailgulek
Copy link

Description:

When we load a context around an in-thread event, we want to paginate backwards and forwards from there and load older and newer messages in a thread, respectively. We have a dir parameters in /messages api to paginate in both directions in a room timeline. We need something similar for /relations api to achieve the same thing on a thread timeline.

@clokep clokep added the A-Threads Threaded messages label Feb 7, 2022
@clokep
Copy link
Member

clokep commented Feb 7, 2022

This was discussed a little bit in the MSC: matrix-org/matrix-spec-proposals#2675 (comment)

uhoreg/matrix-doc@6a76e5c might be vaguely related to this, but was essentially undone via uhoreg/matrix-doc@bcf7d15.

MSC2946 says this API is meant to act the same as /messages, maybe it was just an oversight that dir was not included?

@clokep
Copy link
Member

clokep commented Feb 7, 2022

matrix-org/matrix-doc@8e532ac (#2675) seems to have removed the reference to dir, maybe based on the conversation at matrix-org/matrix-spec-proposals#2675 (comment)

@clokep
Copy link
Member

clokep commented Feb 7, 2022

So the result of this is that this is "as-specced" from MSC2675, but I wrote MSC3715 to add them.

@clokep clokep added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Feb 7, 2022
@clokep clokep linked a pull request Feb 8, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Threads Threaded messages T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants