-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
matrix.org
exposes unstable endpoint https://matrix.org/_matrix/client/unstable/im.nheko.summary/rooms/{roomId}/summary
#12562
Comments
according to @t3chguy it's only a fallback, so it should be safe to disable it. |
No, I said it has a fallback. It is the primary, if you disable it you'll instead have a publicRooms request for iirc 10000 rooms for each matrix.to load |
This was done as part of delight, this issue must be raised with them. The /publicRooms fallback doesn't contain is_space so will regress the matrix.to behaviour for space links. |
argh. So it's a critical feature for matrix.to? We can't have a shipped product relying on unstable endpoints forever. We need to at least have a plan to fix this. I'll raise it internally. |
Only critical for space link previews, not for the other 95% of functionality. Without it spaces will look just like regular rooms |
Having clarified with @t3chguy, it seems that without this endpoint, the following will happen on matrix.to:
Note that all these things are already true for anyone who chooses to configure |
It's also worth noting that Element Android has code that refers to this endpoint, but given EA is used regularly against non- |
I updated #11507 and matrix-org/matrix-spec-proposals#3266 now, so an alternative to removing it would be to FCP the MSC and then either stabilize it or remove it depending on the outcome of the FCP. |
I don't see the problem with this: This would be fine as long as there is code that falls back when this endpoint is not present, it has "unstable" in the endpoint path, and at this stage in matrix development, with global versions being properly underway, there should be no ambiguity as to how clients handle this. |
You don't see a problem with |
I don't see a problem in it in that clients should know there is a proper procedure around By not exposing this it might appear to fix this specific problem, but it does't fix the wider problem (not regarding proper procedure around |
This is part of MSC3266, but exposing it on matrix.org encourages clients to use it (see matrix-org/matrix.to#266)
We should plan to disable it, to stop clients being tempted to depend on it.
The text was updated successfully, but these errors were encountered: