Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Try moving methods that call add_push_rule to PushRuleStore #12764

Closed
DMRobertson opened this issue May 17, 2022 · 0 comments · Fixed by #12772
Closed

Try moving methods that call add_push_rule to PushRuleStore #12764

DMRobertson opened this issue May 17, 2022 · 0 comments · Fixed by #12772
Labels
good first issue Good for newcomers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@DMRobertson
Copy link
Contributor

Noticed in https://github.com/matrix-org/synapse/pull/12717/files#r873957164.

We seem to have two methods on the PushRulesWorkerStore which call add_push_rule. That requires write access to the push rules tables, which I think is usually reserved for the non-worker PushRuleStore. I think we should

  • Move those methods to the PushRuleStore subclass
  • Fixup any mypy complaints about redundant type-ignores
  • Check tests pass in CI.
@DMRobertson DMRobertson added good first issue Good for newcomers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels May 17, 2022
@DMRobertson DMRobertson mentioned this issue May 17, 2022
Merged
4 tasks
@ajr0d ajr0d mentioned this issue May 17, 2022
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move methods that call add_push_rule to PushRuleStore
1 participant
@DMRobertson