You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
POST /_matrix/client/v3/keys/query can take a long time.
When clients retry the request, the new request gets queued behind the previous one by E2eKeysHandler._query_devices_linearizer, so retrying a request that timed out only makes response times worse.
The text was updated successfully, but these errors were encountered:
squahtx
added
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
S-Tolerable
Minor significance, cosmetic issues, low or no impact to users.
labels
May 26, 2022
Per #13518: this manifests in thousands of requests to /_synapse/replication/user_device_resync on the main process, which are handled by ReplicationUserDevicesResyncRestServlet.
erikjohnston
added
S-Major
Major functionality / product severely impaired, no satisfactory workaround.
T-Defect
Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
and removed
S-Tolerable
Minor significance, cosmetic issues, low or no impact to users.
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
labels
Aug 18, 2022
POST /_matrix/client/v3/keys/query
can take a long time.When clients retry the request, the new request gets queued behind the previous one by
E2eKeysHandler._query_devices_linearizer
, so retrying a request that timed out only makes response times worse.To prevent the linearizer queue from building up too much, we can enable cancellation for the endpoint.
There's a previous audit of
/rooms/$room_id/members
at we shouldn't process requests where the requester has timed out/gone away #3528 (comment), which may or may not have some overlap.@cancellable
and attach it to the methods you've audited@cancellable
flag to the endpointawait
during request handling #12674)The text was updated successfully, but these errors were encountered: