This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Improve performance of getting unread counts in rooms #13119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/push_actions_perf
branch
from
7603dcd
to
8845dfd
Compare
squahtx
approved these changes
Jun 28, 2022
Comment on lines
800
to
815
| @overload | ||
| def get_stream_id_for_event_txn( | ||
| self, | ||
| txn: LoggingTransaction, | ||
| event_id: str, | ||
| allow_none: Literal[True], | ||
| ) -> int: | ||
| ... | ||
|
|
||
| @overload | ||
| def get_stream_id_for_event_txn( | ||
| self, | ||
| txn: LoggingTransaction, | ||
| event_id: str, | ||
| ) -> int: | ||
| ... |
There was a problem hiding this comment.
Can we get away with one fewer overload if we include the default value for allow_none?
Suggested change
| @overload | |
| def get_stream_id_for_event_txn( | |
| self, | |
| txn: LoggingTransaction, | |
| event_id: str, | |
| allow_none: Literal[True], | |
| ) -> int: | |
| ... | |
| @overload | |
| def get_stream_id_for_event_txn( | |
| self, | |
| txn: LoggingTransaction, | |
| event_id: str, | |
| ) -> int: | |
| ... | |
| @overload | |
| def get_stream_id_for_event_txn( | |
| self, | |
| txn: LoggingTransaction, | |
| event_id: str, | |
| allow_none: Literal[True] = True, | |
| ) -> int: | |
| ... |
There was a problem hiding this comment.
Err, yes. I got confused and these type hints are actually wrong (allow_none=True should return an Optional)
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.