Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't process /send requests for users who have hit their ratelimit #13134

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Jun 29, 2022

Currently we check the ratelimit for a /send request after quite a bit of processing has already occurred. This PR adds a ratelimit check much earlier in the processing, reducing unnecessary processing and remediating performance delays caused by processing over-ratelimit requests. Fixes #13072.

@H-Shay H-Shay requested a review from a team as a code owner June 29, 2022 21:18
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@H-Shay H-Shay merged commit 046a651 into develop Jun 30, 2022
@H-Shay H-Shay deleted the shay/ratelimit branch June 30, 2022 16:22
@H-Shay
Copy link
Contributor Author

H-Shay commented Jun 30, 2022

Merged.

@H-Shay H-Shay restored the shay/ratelimit branch June 30, 2022 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We do lots of processing of /send requests for users who have hit their ratelimit
2 participants