Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Audit and/or add validation to endpoints in synapse/rest/client/account.py #13183

Closed
14 tasks done
Tracked by #13147
DMRobertson opened this issue Jul 5, 2022 · 0 comments · Fixed by #13832
Closed
14 tasks done
Tracked by #13147

Audit and/or add validation to endpoints in synapse/rest/client/account.py #13183

DMRobertson opened this issue Jul 5, 2022 · 0 comments · Fixed by #13832
Assignees
@DMRobertson
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Milestone
Validate data pas...

Comments

@DMRobertson
Copy link
Contributor

DMRobertson commented Jul 5, 2022 •
edited
Loading

Processed

Todo

No action

  • AddThreepidEmailSubmitTokenServlet, GET only
  • WhoamiRestServlet, GET only
  • ThreepidRestServlet
    • GET: nothing to do
    • Going to ignore POST body: it's deprecated and seemingly unused
@DMRobertson DMRobertson mentioned this issue Jul 5, 2022
Open
75 tasks
@DMRobertson DMRobertson self-assigned this Jul 5, 2022
This was referenced Jul 5, 2022
Open
Merged
@clokep clokep changed the title Audit and/or add validation to endpoitns in synapse/rest/client/account.py Audit and/or add validation to endpoints in synapse/rest/client/account.py Jul 5, 2022
@squahtx squahtx added P2 T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jul 12, 2022
@DMRobertson DMRobertson added Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution S-Tolerable Minor significance, cosmetic issues, low or no impact to users. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P2 labels Aug 30, 2022
@DMRobertson DMRobertson mentioned this issue Sep 1, 2022
Merged
This was referenced Sep 15, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
Milestone
Validate data passed to REST endpoints
Development

Successfully merging a pull request may close this issue.

Last batch of Pydantic for synapse/rest/client/account.py matrix-org/synapse
2 participants
@squahtx @DMRobertson