This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove obsolete RoomEventsStoreTestCase #13200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entirely agreed. Would you be willing to change this PR to do so? |
DMRobertson
added
the
X-Awaiting-Changes
|
Yes, of course :) |
arkamar
changed the title
This method does not exist in `HomeServer` since version `v0.6.0`, where it was removed in commit 3c77d13 - `Kill off synapse.api.events.*`. The method was basically replaced with `get_event_builder_factory` before mentioned removal, except this one place, most probably because all tests are prefixed with `STALE_` and therefore they are silently skipped. They were moved to `STALE_` in version `v0.5.0` in commit 2fcce3b - `Remove stale tests`. Tests from `RoomEventsStoreTestCase` class are not used for last 8 years, I believe the best would be to remove them entirely. Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
|
I don't know why https://github.com/matrix-org/synapse/runs/7231544896?check_suite_focus=true fails. Is it really related to my change? Anyway, it seems I cannot rerun the job. |
squahtx
removed
the
X-Awaiting-Changes
squahtx
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
I don't know why https://github.com/matrix-org/synapse/runs/7231544896?check_suite_focus=true fails. Is it really related to my change? Anyway, it seems I cannot rerun the job.
That test has been flaky lately. After rerunning the job, it passes now.
Looks good, thank you for your contribution!
|
Thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method does not exist in
HomeServersince versionv0.6.0, whereit was removed in commit 3c77d13 -
Kill off synapse.api.events.*.The method was basically replaced with
get_event_builder_factorybefore mentioned removal, except this one place, most probably because
all tests are prefixed with
STALE_and therefore they are silentlyskipped. They were moved to
STALE_in versionv0.5.0in commit2fcce3b -
Remove stale tests.Tests from
RoomEventsStoreTestCaseclass are not used for last 8years, I believe the best would be to remove them entirely.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)