This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Disallow /batch_send
usage in a room where the room version doesn't support it or is not the room creator
#13216
Labels
S-Tolerable
Minor significance, cosmetic issues, low or no impact to users.
T-Defect
Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Description
Currently, we just don't persist the insertion, batch, and marker events but we shouldn't allow the
/batch_send
usage in the first place to make it more obvious.Steps to reproduce
I created a test case here that reproduces this issue 100% of the time. It's a near copy-paste of another one of the batch send test cases, but with different assertion logic.
Homeserver
Branch based off of 0c95313
Synapse Version
{"server_version":"1.61.0 (b=develop,f33356e8f8)","python_version":"3.10.4"}
Installation Method
No response
Platform
NixOS. Running in Python virtualenv.
Relevant log output
Anything else that would be useful to know?
No response
The text was updated successfully, but these errors were encountered: