Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: handle incoming federated join requests during a faster join #13290

Closed
richvdh opened this issue Jul 15, 2022 · 1 comment · Fixed by #13416
Closed

Faster joins: handle incoming federated join requests during a faster join #13290

richvdh opened this issue Jul 15, 2022 · 1 comment · Fixed by #13416
Assignees
Labels
A-Federated-Join joins over federation generally suck T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@richvdh
Copy link
Member

richvdh commented Jul 15, 2022

If we get an incoming send_join during a faster-join resync, I think that we will reply with incomplete results. (Either an incomplete server list if it's a faster-join request, or incomplete state list if not.)

@richvdh richvdh added this to the Faster joins (further work) milestone Jul 15, 2022
@richvdh richvdh changed the title Faster joins: handle join requests during a faster join Faster joins: handle incoming federated join requests during a faster join Jul 15, 2022
@squahtx squahtx added A-Federated-Join joins over federation generally suck T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jul 15, 2022
@richvdh
Copy link
Member Author

richvdh commented Jul 28, 2022

In this situation, I think we should behave the same way we would if we were not in the room at all, which is (currently) to reject it with a 404.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Federated-Join joins over federation generally suck T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
3 participants