Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Complement TestRestrictedRoomsRemoteJoinFailOver is flakey #14986

Closed
DMRobertson opened this issue Feb 3, 2023 · 2 comments · Fixed by matrix-org/complement#614
Closed

Complement TestRestrictedRoomsRemoteJoinFailOver is flakey #14986

DMRobertson opened this issue Feb 3, 2023 · 2 comments · Fixed by matrix-org/complement#614
Assignees
@squahtx
Labels
A-Federated-Join joins over federation generally suck T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Flake Tests that give intermittent failures

Comments

@DMRobertson
Copy link
Contributor

https://github.com/matrix-org/synapse/actions/runs/4086884506/jobs/7046775641
@DMRobertson DMRobertson added A-Federated-Join joins over federation generally suck T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Flake Tests that give intermittent failures Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact labels Feb 3, 2023
@DMRobertson DMRobertson mentioned this issue Feb 3, 2023
Merged
@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/4109460059/jobs/7091350755

@DMRobertson DMRobertson mentioned this issue Feb 7, 2023
Merged
@squahtx squahtx self-assigned this Feb 15, 2023
This was referenced Feb 16, 2023
Merged
Merged
@squahtx
Copy link
Contributor

squahtx commented Feb 16, 2023

This turned out to not be related to faster room joins.

@squahtx squahtx removed this from the Remaining faster remote join work milestone Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@squahtx squahtx

Labels
A-Federated-Join joins over federation generally suck T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Flake Tests that give intermittent failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TestRestrictedRoomsRemoteJoinFailOver flake due to race matrix-org/complement
2 participants
@squahtx @DMRobertson