Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Synapse implements closed MSC2000 #16415

Closed
t3chguy opened this issue Oct 2, 2023 · 2 comments
Closed

Synapse implements closed MSC2000 #16415

t3chguy opened this issue Oct 2, 2023 · 2 comments
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@t3chguy
Copy link
Member

t3chguy commented Oct 2, 2023

Description

https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html#password_config returns error codes defined from MSC2000 which was abandoned and thus should be removed from implementations within 3 months.

Steps to reproduce

  • Enable password_config policy MSC2000 implementation
  • Register using a password not conforming to the policy

Homeserver

localhost

Synapse Version

v1.93.0

Installation Method

Docker (matrixdotorg/synapse)

Database

pg

Workers

Single process

Platform

Docker

Configuration

password_config:
  policy:
    require_digit: true

Relevant log output

N/A

Anything else that would be useful to know?

No response
@t3chguy t3chguy mentioned this issue Oct 2, 2023
Closed
@clokep clokep changed the title Synapse defines stable identifiers from closed MSC2000 Synapse implements closed MSC2000 Oct 2, 2023
@clokep clokep added A-Spec-Compliance places where synapse does not conform to the spec S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 2, 2023
@erikjohnston
Copy link
Member

This should be mostly magically fixed by us switching to OIDC, at which point we'll rip out all of this code.

@turt2live
Copy link
Member

Duplicate of #15645 ?

@clokep clokep closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clokep @turt2live @t3chguy @erikjohnston