Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

We accept stupid events over backfill, causing state res storms #3124

Closed
richvdh opened this issue Apr 20, 2018 · 1 comment · Fixed by #10645
Closed

We accept stupid events over backfill, causing state res storms #3124

richvdh opened this issue Apr 20, 2018 · 1 comment · Fixed by #10645
Labels
A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) A-Validation 500 (mostly) errors due to lack of event/parameter validation z-minor (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Apr 20, 2018

If somebody creates an event with hundreds of prev_events, we will (since #3118) reject it when it arrives over federation. However, we may then try to backfill it, and will accept it and do an awful state resolution.

Fixing this is tricky as simply rejecting the event would break back-pagination for the room in question, in the same way that it is currently broken by events which don't have the correct signature (#3121). A solution to #3121 would probably mean that we could also fix this.
@richvdh richvdh mentioned this issue Apr 20, 2018
Merged
@neilisfragile neilisfragile added p1 z-minor (Deprecated Label) labels May 9, 2018
@florianjacob florianjacob mentioned this issue Sep 30, 2019
Closed
@richvdh
Copy link
Member Author

richvdh commented Sep 22, 2020

now that #3121 is fixed, it may be more tractable to fix this one. Throwing it into the "validation" bucket.

@richvdh richvdh added the A-Validation 500 (mostly) errors due to lack of event/parameter validation label Sep 22, 2020
@richvdh richvdh mentioned this issue Sep 22, 2020
Open
@richvdh richvdh mentioned this issue Aug 18, 2021
Merged
@MadLittleMods MadLittleMods added the A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) label Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) A-Validation 500 (mostly) errors due to lack of event/parameter validation z-minor (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make backfill and get_missing_events use the same codepath matrix-org/synapse
3 participants
@neilisfragile @MadLittleMods @richvdh