Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

joining a large room completely hosed a homeserver #3527

Open
richvdh opened this issue Jul 13, 2018 · 2 comments
Open

joining a large room completely hosed a homeserver #3527

richvdh opened this issue Jul 13, 2018 · 2 comments
Labels
A-Federated-Join joins over federation generally suck A-Performance Performance, both client-facing and admin-facing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@richvdh
Copy link
Member

richvdh commented Jul 13, 2018

somewhat related to #3495, but seen from the other end. The joining server thought the join failed, but other servers in the room think it joined successfully, and are now sending it events. The joining server, however, is missing a bunch of important stuff, so is sending off millions of get_missing_events requests, which are slow (cf #3526), end up getting queued (cf #3524), and 429ed, and federation basically ends up breaking down

@richvdh
Copy link
Member Author

richvdh commented Jul 13, 2018

we fixed this by kicking the user back out of the room and restarting the joining server.

@richvdh
Copy link
Member Author

richvdh commented Jul 13, 2018

Once the get_missing_events fails (as it will, thanks to #3444), we end up doing a /state_ids/ request instead, and then hundreds of thousands of /event requests.

@neilisfragile neilisfragile added p1 z-major (Deprecated Label) A-Performance Performance, both client-facing and admin-facing labels Jul 23, 2018
@erikjohnston erikjohnston added A-Federated-Join joins over federation generally suck S-Major Major functionality / product severely impaired, no satisfactory workaround. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed z-p1 z-major (Deprecated Label) labels Sep 7, 2022
@kittykat kittykat added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Federated-Join joins over federation generally suck A-Performance Performance, both client-facing and admin-facing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

4 participants