Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Workers fail to start without a listener #4783

Closed
turt2live opened this issue Mar 2, 2019 · 4 comments
Closed

Workers fail to start without a listener #4783

turt2live opened this issue Mar 2, 2019 · 4 comments

Comments

@turt2live
Copy link
Member

People keep trying to set up workers without a listener (not even a metrics one), and this causes a configuration error on startup. Should probably still work, even if running blind is not the best choice

@evilham
Copy link
Contributor

evilham commented Mar 2, 2019

For context: https://matrix.to/#/!HsxjoYRFsDtWBgDQPh:matrix.org/$15515594544gbcvx:unchat.cat?via=matrix.org&via=chat.weho.st&via=disroot.org

My issue turned out not to be exactly this, still there is room for improvement. I'd be happy to add a PR with better documentation if this is expected behaviour.

If OTOH cases like the appservice and pusher workers, not having worker_listeners defined in the configuration is OK, this would require defaulting to an empty list and some code changes which I could also take a look into.

@evilham
Copy link
Contributor

evilham commented Mar 5, 2019

Adding some more information: setting worker_listeners: [] also works for, e.g. appservice and pusher.

@erikjohnston
Copy link
Member

Hopefully #4853 fixes this

@evilham
Copy link
Contributor

evilham commented Mar 15, 2019

Indeed, @turt2live can close this now :)

@richvdh richvdh closed this as completed Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants