public_baseurl spelling confusion

[cueman]

Description

If you do not set public_baseurl and configure synapse for password reset emails, you get an error message that tells you it is missing "public_base_url" - with an extra underscore in there.

I went looking for public_base_url because of this, and then realised it should be public_baseurl.

There are two places where there is a reference to public_base_url, and both should be changed to public_baseurl:

• synapse/config/emailconfig.py
• synapse/rest/well_known.py

Steps to reproduce

• do not set public_baseurl in homeserver.yaml
• configure synapse for password reset emails
• restart synapse
• logs provide message:

Password resets emails are configured to be sent from this homeserver due to a partial 'email' block. However, the following required keys are missing: public_base_url

Version information

• Homeserver: private server

• Version: 1.3.1 and can be seen in master for tag v1.3.1 and the current tip of branch develop

• Install method:

ubuntu apt install as described here:

• https://github.com/matrix-org/synapse/blob/master/INSTALL.md

• Platform: ubuntu 18.04

[richvdh]

fixed by #5909